Files
bookshelf/docs/HANDOFF.md
T
Spriteandclaude 0455794603 server: anonymous LIST of users returns 403, not 200 with an empty array
Found while re-verifying the security posture against the public hostname now
that the server is internet-exposed. pb_hooks/main.pb.js covered bookcases,
shelves and books but never users, so an anonymous GET of the accounts
collection answered 200 with an empty array.

Nothing leaked: two real accounts exist and the declarative listRule filtered
both out, so no account, email or id was ever visible to an anonymous caller.
But "200 with []" is the exact wrong signal this hook exists to remove — some
clients read it as an allowed request — and the accounts collection is the last
place to leave it. Defensible while the server was localhost-only; not now.

Re-verified over the internet after restarting the service: books, shelves,
bookcases and users all 403 anonymous, self-registration 403, health 200.

Also re-verified that login still works, since this hook now runs on a
collection the app authenticates against: auth-with-password returns 200 with a
token, and an authenticated LIST of all four collections still returns 200. The
hook rejects unauthenticated list/search only, and auth-with-password is not a
list request.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPpdG8VnRfS3KkisR3HUAE
2026-09-12 17:47:43 +00:00

39 KiB
Raw Blame History

Bookshelf — session handoff

Written 2026-09-06 by the Opus orchestrator, after a sprite restart forced a fresh session.

FIRST COMMAND OF A NEW SESSION — is a wave already finished?

Workers run fully detached (hazard #5) and OUTLIVE the orchestrator. A wave can finish while no orchestrator exists. Nothing will "notify" a session that was not running, so completion is recorded ON DISK. Run this before anything else:

cd ~/bookshelf && cat logs/WAVE*-DONE 2>/dev/null; \
  pgrep -fc 'run-task\.sh' ; tail -2 logs/*.state
  • logs/WAVE<N>-DONE exists -> that wave's workers have STOPPED. Read it, then independently verify (assembleDebug + testDebugUnitTest + git status --porcelain) before accepting anything. Workers self-report optimistically; two of three waves so far over-claimed.
  • no sentinel + pgrep count > 0 -> still running; arm a Monitor and wait.
  • no sentinel + count 0 -> workers were KILLED. Check logs/<name>.json: 0 bytes means killed, not failed (hazard #3). Relaunch with setsid per hazard #5; run-task.sh will RESUME the existing session id rather than restart, so context/quota is preserved.

The sentinel is written by tasks/wave-sentinel.sh, itself launched detached: setsid nohup ./tasks/wave-sentinel.sh WAVE3-DONE E1-shell E2-books </dev/null >/dev/null 2>&1 & An in-process Monitor is only a convenience for a LIVE orchestrator; it dies with the process and caps at 1h. Never rely on it as the record that a wave completed.

Read these first, in order

  1. docs/SPEC.md — the authoritative product/technical contract. Unchanged and still correct. Every worker prompt must point at it. Do not restate it; do not let it drift.
  2. This file — operational state, what's done, what bit us, what's next.

Operating model (the user explicitly asked for this — keep it)

The user is on the $20/mo Pro plan and wants Opus used sparingly.

  • Opus = orchestrator only. Write specs, launch workers, verify results, decide. Do NOT write app code yourself. Do NOT read large files into Opus context.
  • Sonnet = all implementation, via claude -p (NOT the Agent tool — the user asked for claude -p specifically, and it keeps worker output out of the orchestrator's context).
  • Read worker output via logs/<name>.summary / jq -r '.result', never by cat-ing source.
  • Quota status: user reported 62% of the 5h window consumed at ~19:45 on 09-05. Worker A alone cost $2.40 / 85 turns. Budget accordingly; prefer resuming a session over restarting one.

How to launch a worker (BOTH steps — the guard is not optional)

cd ~/bookshelf
setsid nohup ./tasks/run-task.sh <NAME> ./tasks/<NAME>.txt </dev/null >/dev/null 2>&1 &
setsid nohup ./tasks/wave-guard.sh WAVE<N>-DONE <NAME> [<NAME>...] </dev/null >/dev/null 2>&1 &

Without the guard the sprite auto-suspends as soon as the user's console goes idle and the whole wave is lost (hazard #5). The guard holds a /v1/tasks lease, renews it every 15 min, writes logs/WAVE<N>-DONE at the end, and releases the lease so the box can sleep. Check it with sprite-env curl /v1/tasks and cat logs/wave-guard.log. tasks/run-task.sh is quota-aware: on a usage-limit error it sleeps POLL (600s) and resumes the SAME session rather than restarting, up to MAX_WALL (24h), and does not count quota waits against its 3-strike hard-failure budget. It writes: logs/<name>.json (final result), .err, .sid (session id), .state (progress), .summary.

HAZARD — do not repeat: never edit run-task.sh while workers are running. Bash reads scripts by byte offset; swapping the file mid-run makes live workers resume inside unrelated code and can spawn duplicate claude processes that burn quota on finished work. If you must change it, write a NEW file and use that for the next wave.

Environment

  • JDK 21: ~/toolchain/jdk21 (system java is 25 — too new for AGP, do not use it)
  • Android SDK: ~/toolchain/android-sdk (platforms;android-37.0, build-tools;37.0.0, platform-tools)
  • No KVM, no emulator. Verify only via ./gradlew assembleDebug, JVM unit tests, and Paparazzi PNG rendering. Never claim the app was "run".
  • PocketBase v0.40.2 service, bound to 0.0.0.0:8090 and INTERNET-EXPOSED via the sprite proxy at https://bookshelf-dev-b2jqx.sprites.app (the service is registered with --http-port 8090, so the proxy routes to it). This is the live server the user's phone talks to. Restart: sprite-env services restart pocketbase. Logs: /.sprite/logs/services/pocketbase.log. See "Where the server lives" below.
  • Superuser creds: server/.dev-credentials (gitignored).

Where the server lives — ANSWERED 2026-09-12: on this sprite, publicly

This was an open question through waves 1-7 and it now has an answer: for now the server stays here on the sprite and is reachable from the open internet. The user's phone talks to https://bookshelf-dev-b2jqx.sprites.app. Earlier notes in this file and in server/deploy/ said the opposite (localhost-only, unreachable from outside); they were true when written and are now corrected in place. server/deploy/ still documents systemd/Docker/Tailscale for an eventual move to home hardware — that is a future option, not what is running.

Consequences that were not true when the app was designed:

  1. PocketBase's own API rules are now the ONLY thing between this library and the internet. There is no NAT, no Tailscale, no reverse proxy in front of it. The security curls in "Verification standard" below stopped being a formality the day this changed — run them against the PUBLIC hostname, not 127.0.0.1, because localhost cannot tell you what the world can reach.
  2. The sprite auto-suspends when idle and wakes on an incoming HTTP request (that is what --http-port buys). So the server is still "often unreachable" in the sense SPEC's offline-first rule cares about — just for a different reason than residential NAT, and with a cold-start delay on the first request after a pause rather than a hard failure. The size of that delay has not been measured; if a sync or a first login ever looks pathologically slow, measure it before assuming a bug in the app.
  3. The URL is a sprite-scoped hostname. If this sprite is ever renamed or rebuilt the URL changes, and every phone has to be re-pointed at it on the setup screen. That is an argument for moving to Tailscale + real hardware eventually, not a reason to hardcode anything.

Posture re-verified against the PUBLIC hostname, 2026-09-12

Check (anonymous, over the internet) Result
GET /api/collections/books/records 403 {"message":"Authentication required."}
GET /api/collections/shelves/records 403
GET /api/collections/bookcases/records 403
POST /api/collections/users/records (self-registration) 403
GET /api/health 200 (intended — it is a health check and leaks nothing)
GET /api/collections/users/records 403 (was 200 {"items":[]} — fixed same day, below)

The users gap, found and closed on 2026-09-12. users LIST was answering 200 with an empty array instead of 403. No data escaped — there are two real accounts in the DB and an anonymous caller saw neither, because listRule filters the rows out — but the status code was wrong, and it was the exact PocketBase quirk pb_hooks/main.pb.js exists to paper over. That hook listed only bookcases, shelves, books; users was never added, which was defensible while the server was localhost-only and is not now that the collection is world-reachable.

Fixed by adding "users" to the hook's collection list and restarting the service. Re-verified over the internet after the restart: all four collections 403 anonymous, self-registration 403, health 200. Login was re-verified too, because this hook runs on a collection the app authenticates against: POST /api/collections/users/auth-with-password still returns 200 with a token, and an authenticated LIST of all four collections still returns 200. The hook only rejects UNAUTHENTICATED list/search, and auth-with-password is not a list request.

STATE: what is DONE

Wave 1A — server: COMPLETE and verified by the orchestrator (not just self-reported)

server/ contains setup-schema.sh (idempotent), create-user.sh, pb_hooks/main.pb.js, pb_migrations/, deploy/ (systemd unit, Dockerfile, compose, backup.sh, README covering Tailscale vs port-forward+Caddy), README.md, .gitignore.

Independently re-verified on 09-06 after fixing the service:

Check Result
anonymous LIST books/shelves/bookcases 403 / 403 / 403
anonymous self-registration 403
/api/health 200

pb_hooks/main.pb.js is INTENTIONAL, not scope drift. PocketBase's listRule is a row filter, so anonymous LIST would otherwise return 200 [] instead of an error. The hook forces 403. Keep it; it is why the table above passes. It is auto-loaded by the stock binary.

Wave 1B — Android scaffold + design system: COMPLETE, verified by the orchestrator

The pre-restart worker had gotten much further than the last handoff recorded. On 09-06 the orchestrator found everything on disk (theme, 7 shared components, MainActivity, BookshelfApplication, Paparazzi test, all 8 Literata TTFs) and only THREE compile errors, all the same class of trivial import bug — fixed directly by the orchestrator rather than spending a worker session on two-line edits:

  • import androidx.compose.foundation.layout.weight (x2: BookshelfScaffold.kt, the Paparazzi test) — that resolves to the internal RowColumnParentData.weight. weight is a ColumnScope/RowScope member; it needs NO import. Delete the line.
  • SyncStatusBar.kt was missing import androidx.compose.runtime.getValue, so val x by transition.animateFloat(...) had no delegate.
Check Result
./gradlew assembleDebug exit 0 — app-debug.apk, 47MB
./gradlew testDebugUnitTest exit 0
./gradlew recordPaparazziDebug exit 0 — 10 PNGs, light+dark

Snapshots: app/app/src/test/snapshots/images/. The orchestrator eyeballed scaffold-light: warm paper ground, Literata serif title, thin gold hairline rule. Matches the design language.

Repo is now a git repo

git init + baseline commit 8bcd9f7 at the 1B-green point. This is deliberate: it lets the orchestrator verify a wave with git diff --stat / git log instead of reading source files into Opus context, and gives a rollback that isn't a whole-sprite checkpoint restore. Root .gitignore covers build outputs, server/pb_data, .dev-credentials, worker logs.

STATE: what is IN FLIGHT

Wave 2 — C (data layer) + D (metadata/scanning): LAUNCHED 09-06 ~01:59Z, running in parallel

Prompts: tasks/C-data.txt, tasks/D-metadata.txt. Sessions: C-data=c2b92ca5-55d7-49b2-8a89-dc36e3ba4c9f, D-metadata=9a2c0de8-e475-4a43-9302-bc66889ee2bd

Two coordination devices were put in place before launch; keep them for wave 3:

  1. tasks/gw — a flock-serialized gradle wrapper. Both workers share ONE Gradle project dir; concurrent ./gradlew runs clobber each other's outputs. Both prompts forbid ./gradlew and require tasks/gw. Reuse this for every future parallel wave.
  2. Disjoint file ownership, stated as a hard boundary in each prompt. C owns data.local, data.remote, data.repo, data.prefs, AppContainer, BookshelfApplication. D owns data.metadata and ui.scan plumbing. NEITHER may touch app/build.gradle.kts or libs.versions.toml — the orchestrator confirmed every wave-2 dependency is ALREADY declared and wired, so there is no legitimate reason for a worker to edit a build file. D must not wire MetadataRepository into AppContainer (C owns it); D reports the one-line snippet instead, to be applied later.

STATE: what is NOT done

Waves 3-4 — not started. Prompts not yet written.

  • Wave 3 (after C+D land and are verified): E — the six screens (setup, library, detail, scan, locations, settings).
  • Wave 4: F — Paparazzi screenshots for the user to judge the look, release keystore + signed APK, top-level README, end-to-end sync test against the live PocketBase.

Gotchas already paid for — do not rediscover

  1. Migration filename ↔ _migrations desync. Worker A renamed 1788636563_created_books.js to ...564... to fix an alphabetical-replay ordering bug (books sorted before shelves, breaking the relation). Correct for fresh instances, but the dev DB still had the old name recorded applied, so PocketBase tried to re-create books and crash-looped 9 times. Fixed via UPDATE _migrations SET file=.... If you ever rename a migration, update that table too. DB backup: scratchpad data.db.bak.
  2. Rule semantics: in PocketBase "" means PUBLIC, null means superuser-only. Confusing these is exactly how the library would end up world-readable.
  3. claude -p --output-format json writes its log only at exit; a 0-byte .json means the worker is still running or was killed, not that it failed.
  4. System JDK is 25 and will break AGP. Workers must export JAVA_HOME=~/toolchain/jdk21 (run-task.sh already does).

Verification standard (hold workers to this)

Workers self-report optimistically. Before accepting any wave:

  • Re-run the security curls above yourself. The user's stated requirement is that this not be "accessible to everyone in the world"; that check is non-negotiable and cheap.
  • Require assembleDebug + test exit 0, and confirm artifacts exist on disk.
  • Treat "I couldn't get Paparazzi working so I skipped screenshots" as a finding to report to the user, not something to paper over — the user explicitly cares how this looks.

Open questions for the user (not yet asked — deferred, not forgotten)

  • Where the server will actually live (home box vs a sprite) — ANSWERED 2026-09-12: it stays on this sprite, internet-exposed. See "Where the server lives" above.
  • Their two account emails, for create-user.sh. Not needed until the app can log in.

HAZARD #5 — THE SPRITE AUTO-SUSPENDS; detached workers do NOT keep it awake

This is the real cause of the wave-3 loss on 09-06, and an earlier note in this file blamed the wrong thing (it claimed nohup process-group semantics). Correct diagnosis, credit to the user: /.sprite/llm.txt says "When idle, sprites pause automatically" and "Services and sessions keep sprites alive." A detached background process is on NEITHER list. Wave 3 was launched at 03:25 with setsid nohup, the user's console session went away, the sprite went COLD, and all process state was lost. Evidence: at 10:07 uptime read "up 2 min" (boot 10:05:40) while the workers' session files stopped at 03:25 — a machine that stopped and rebooted, not a signalled process.

FIX — hold a sprite task lease for the duration of the wave. Undocumented in /.sprite/docs but live on the API socket: POST /v1/tasks {"name":"","expire":"3600s"} -> holds the sprite HOT GET /v1/tasks -> list active leases DELETE /v1/tasks/ -> release

  • max expire is 3600s (a 2h request is rejected: "exceeds maximum 3600 seconds")
  • re-POSTing a live name returns 409, so RENEWAL = DELETE then POST
  • the lease lives server-side, so it keeps the box up independently of any process; a renewal loop running on the sprite therefore sustains itself

tasks/wave-guard.sh does all of this: acquires the lease, renews every 15 min while workers run, then writes logs/WAVE<N>-DONE and RELEASES the lease so the sprite can suspend instead of idling hot on the user's dime. Launch it detached alongside a wave: setsid nohup ./tasks/wave-guard.sh WAVE3-DONE E1-shell E2-books </dev/null >/dev/null 2>&1 & Still launch workers with setsid (needed so they survive the orchestrator exiting), but understand that alone it does NOT survive a suspend. The lease is what does.

HAZARD #6 — pgrep -f / pkill -f match YOUR OWN shell

Bitten three times in one session, once fatally: pkill -f wave-sentinel.sh killed the orchestrator's own shell (exit 144) because the bash -c command line contained that literal string. Same bug made pgrep -f "claude -p" report a phantom running worker. Use the bracket trick (ps aux | grep "[c]laude -p") or match on argv shape (ps -eo pid,args | grep -E "tasks/(wave-guard|run-task)" | grep -v grep).

HAZARD #7 — never git add -A while workers are running

The orchestrator committed twice (10:09, 10:22) while E1/E2 were actively writing files. git add -A swept half-finished wave-3 SOURCE into commits whose messages said "orchestration tooling". That silently defeats the whole reason this repo exists as git: per-wave git diff --stat verification. It also produced a fake-clean git status, which briefly looked like the workers had produced nothing at all. Rules:

  • While a wave is in flight, commit with an EXPLICIT pathspec only, e.g. git add docs/HANDOFF.md tasks/ && git commit ... — never -A, never ..
  • Do the wave's own git add -A commit only AFTER the sentinel exists and the build and tests have been independently verified.
  • If it happens anyway: git reset --soft <last-good>, git reset, then re-commit in honest slices. Safe here — the repo has no remote and checkpoints exist. Done once already (commits d947aa7/058e864 were rebuilt into dbb0726 + a022a1b).

Wave 3 — COMPLETE, verified by the orchestrator on 09-06

E1 (nav/setup/locations/settings) and E2 (library/detail/scan) both reported SUCCESS; E2 took one quota wait and run-task.sh resumed it correctly.

Check Result
assembleDebug exit 0
testDebugUnitTest exit 0 — 91 tests, 0 failures, 0 errors (was 68)
boundary check clean: neither touched build files or the other's packages
Commit a022a1b (32 files, +3081).

Known gaps carried into wave 4 — do not lose these:

  1. Cover pipeline has NEVER run against a real PocketBase. Download-on-create and multipart upload-on-sync were only exercised against fakes (worker C's own report). This is the single most likely place a real bug is hiding. Wave 4 must do a live round-trip against 127.0.0.1:8090.
  2. Settings shows the PocketBase user id, not the email — AuthRepository/SettingsStore never persist the login email (E1's report). Cosmetic, needs a data-layer change.
  3. No Room foreign keys between books/shelves/bookcases (deliberate, worker C).
  4. No emulator on this box: nothing has ever been run, only compiled and unit-tested. Paparazzi PNGs are the only evidence of how any of it actually looks.

Wave 4 — COMPLETE, verified by the orchestrator on 2026-09-08

This is the last planned wave. All of SPEC's build/verify gates now pass.

Check Result
./tasks/gw assembleDebug exit 0
./tasks/gw testDebugUnitTest exit 0 — 102 tests, 1 skipped, 0 failures, 0 errors
./tasks/gw assembleRelease exit 0
signed APK app/app/build/outputs/apk/release/app-release.apk, 41,777,344 bytes
apksigner verify --print-certs V2 signer CN=Bookshelf, O=Montanaro — the real release key, not the debug cert
secrets app/release-keystore.jks + app/keystore.properties gitignored and NOT committed — re-verified against the staged file list before committing

The skipped test is LiveSyncTest — opt-in, it needs the live PocketBase. It PASSED in wave 4's first half; the cover round-trip gap from wave 3 is closed.

Commits 5455df2 (app work) + 0f47ee9 (orchestration). Pushed to origin/main (ssh://git@git.jfmonty2.com:2022/jfmonty2/bookshelf.git) — the repo now has a remote, so pushing after each commit is the norm.

How wave 4 actually ended — F3 never reported

F3-release wrote all four deliverables between 20:34 and 20:46 on 09-08 and then could not finish. Two separate mechanisms:

  • claude -p terminates background tasks after 600s (Background tasks still running after 600s; terminating. Set CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS=0 to wait indefinitely.). F3 had launched assembleRelease in the background with a Monitor and ended its turn saying it would report when done — the exact failure its own prompt forbade.
  • It then hit the 5h quota and went into a 600s wait loop, so the service supervisor would have kept re-running verification on finished work indefinitely.

The orchestrator ran the verification itself, wrote logs/WAVE4-DONE by hand (noting it was NOT written by service-worker.sh), and stopped the service. If you launch another worker, set CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS=0 in run-task.sh, or tell the worker to run builds in the FOREGROUND. A worker that backgrounds a 10-minute Gradle build cannot ever report on it.

The one thing wave 4 owed and did not deliver

F3 was asked to say candidly what the rendered screens get WRONG against SPEC's design language, now that they can finally be seen. It never reported. Fourteen new PNGs are on disk, unreviewed by anyone. The user explicitly cares how this looks, so this is the top open item — not a build problem, a design-review one: app/app/src/test/snapshots/images/ (setup, detail, scan ×2, locations, settings, library, scaffold — each light + dark).

STATE: what is NOT done (as of 2026-09-08)

  1. Nobody has looked at the screenshots. See above. Highest-value next step.
  2. The app has still never run on a device or emulator (no KVM on this box). Everything is compile + unit-test + Paparazzi evidence only. Installing the signed APK on a real phone is the only way past this, and it needs the user.
  3. R8 is off. Acceptable per F3's prompt, but the release APK is 41.8MB. Turning it on requires proving Room/Retrofit/kotlinx-serialization/ML Kit survive minification.
  4. Still-open user questions: the two account emails for create-user.sh. (Where the server will live was ANSWERED on 2026-09-12 — it stays on this sprite, internet-exposed. See "Where the server lives" near the top.)

First on-device test — 2026-09-09

The user installed the signed APK on a real phone. It runs. This closes the "never been run" gap that waves 1-4 all carried. Six issues came back; five were fixed directly by the orchestrator in commit 356f639 (they were small, and spinning up Sonnet workers for two-line Compose edits costs more than it saves).

The one worth remembering — BookCover branched on painter.state, but in coil3 that is a StateFlow<State>, not a State. Every is AsyncImagePainter.State.X arm was therefore always false, and because a when used as a statement needs no else, it compiled clean and drew NOTHING — no cover, no placeholder, no error icon. Kotlin emitted "Check for instance is always 'false'" as a warning on four consecutive lines and the build stayed green. Grep the build log for always 'false' before accepting a wave; that warning class is a silent-dead-code detector and this build had it for months.

Two more cover defects sat behind it, both verified against the live service:

  • covers.openlibrary.org/b/isbn/{isbn}-L.jpg answers 200 with a 43-byte 1x1 transparent GIF for an edition with no art. Any image loader calls that a successful load. Only ?default=false turns a miss into a 404.
  • OL's DTO synthesized that URL unconditionally, so MetadataMerger's fill-blanks rule could never reach Google Books' thumbnail. The SPEC'd cover fallback was dead code. Cover URLs now come from OL's own cover object.

Also fixed: sync bar clipped by rounded display corners (now owns its navigation-bar inset, wider horizontal padding, moved into Scaffold's bottomBar slot); setup screen's Password field hidden behind the IME (safeDrawingPadding outside verticalScroll, plus Next/Next/Done IME actions and windowSoftInputMode=adjustResize); library card titles reflowed (20sp leading, author gets its own 4dp gap); scan sheet now names the ISBN and says "Searching…" instead of showing a bare spinner.

Check Result
./tasks/gw assembleDebug exit 0
./tasks/gw testDebugUnitTest exit 0 — 106 tests, 1 skipped, 0 failures
./tasks/gw verifyPaparazziDebug exit 0 against re-recorded snapshots
./tasks/gw assembleRelease exit 0 — 41,777,376 bytes
apksigner verify V2 signer CN=Bookshelf, O=Montanaro — real release key

Open, not started: metadata coverage

The user reported 1 of 3 scans resolving, and asked for research, not a change. Findings are in docs/METADATA-SOURCES.md. Headline: Open Library answered 88% of a 60-ISBN sample, keyless Google Books returned 429 on 60 of 60 requests, and both clients collapse every non-200 into null — so a rate-limited lookup reaches the user as "No match found." Recommended order is a free Google Books API key, then distinguishing "couldn't ask" from "not found", then retry/backoff, before adding any new source. Awaiting the user's decision; do not implement unasked.

Wave 5 — G-diagnostics: IN FLIGHT, launched 2026-09-09 10:42Z

Prompt: tasks/G-diagnostics.txt. Session id in logs/G-diagnostics.sid. Lease bookshelf-wave held and VERIFIED by tasks/wave-guard.sh, sentinel logs/WAVE5-DONE. Launched from a console the user was about to disconnect, so the lease is the only thing keeping the sprite hot — check it first if anything looks stalled: sprite-env curl /v1/tasks and tail logs/wave-guard.log.

Scope: make the app distinguish three outcomes it currently conflates — barcode-didn't-decode (silent today), lookup-request-failed (reported as "No match found"), and genuinely-not-found. SPEC's "Book metadata lookup" and "Barcode scanning" sections were rewritten to state the three-way contract (Found / NotFound / Unavailable) BEFORE launch, so the worker implements a spec rather than inventing one. This is the only wave-5 task; there is no parallel worker, so the disjoint-ownership device isn't needed, but the prompt still forbids build files and every package outside data.metadata + ui.scan.

Why this and not more sources: the two books that failed on the phone (9781883937386, 9781883937676) are BOTH fully present in Open Library, with cover art, and the app's own parser handles their real responses — there are regression fixtures and a test proving it. The coverage hypothesis is dead. See docs/METADATA-SOURCES.md § "What actually failed". Do not let a future worker "fix" this by bolting on a third data source.

Verify before accepting (workers self-report optimistically; two of five waves over-claimed): cd ~/bookshelf && ./tasks/gw assembleDebug && ./tasks/gw testDebugUnitTest
&& ./tasks/gw recordPaparazziDebug && git status --porcelain 107 tests pass today; the count must go UP and nothing may regress. Also grep the build log for always 'false' — that warning class silently blanked every book cover in this app for months and is now an explicit item in the worker's prompt. Then eyeball the two new Paparazzi PNGs (LookupFailed sheet, rejected-barcode overlay) — the user cares how this looks and no worker has ever been trusted on that.

Still open, unchanged: the free Google Books API key (keyless returns 429; worth doing on its own merits but no longer the leading theory), R8 still off so the release APK is 41.8MB and too large to send over the file channel (30MB cap), and the two account emails for create-user.sh. (Where the server will live was ANSWERED on 2026-09-12: it stays on this sprite, internet-exposed.)

Wave 5 — G-diagnostics: COMPLETE, verified by the orchestrator 2026-09-09

Commit 93f972b. The app now distinguishes barcode-didn't-decode from lookup-request-failed from genuinely-not-found; see the commit message and docs/METADATA-SOURCES.md.

Check Result
assembleDebug exit 0
testDebugUnitTest exit 0 — 138 tests, 1 skipped, 0 failures (was 107)
verifyPaparazziDebug exit 0
assembleRelease exit 0 — 41,793,760 bytes, V2 signer CN=Bookshelf
boundary check clean — no build files, no forbidden packages
grep "always 'false'" 0 hits on touched files

The worker was honest this time: everything it claimed checked out. Cost $0.28, 6 turns, one quota wait that run-task.sh resumed correctly.

The orchestrator added one thing the worker's brief didn't cover: the manual-ISBN dialog silently discarded an unparseable entry — the same silent failure this wave existed to eliminate, sitting just outside the prompt's scope. It now marks the field in error and disables "Look up" until the checksum passes. Lesson for future prompts: scope a wave by failure class, not by file list, or the instances of the class that live outside the listed files survive.

HAZARD #8 — the wave-guard can die without writing its sentinel

logs/WAVE5-DONE was written BY HAND. The guard renewed at 11:13, the worker succeeded at 11:21, and the guard neither wrote the sentinel nor logged its "guard exiting" trap line — it was killed outright. The lease expired on its own an hour later.

This breaks the first-command heuristic at the top of this file. "no sentinel

  • pgrep count 0 -> workers were KILLED" was WRONG here: the worker had finished successfully. Use these instead, in this order:
    1. ls -l logs/<name>.json — 0 bytes means killed; non-zero means it finished.
    2. tail logs/<name>.state — says SUCCESS / GIVING UP / WALL CLOCK explicitly.
    3. git status --porcelain — is there actually work in the tree? The sentinel is a convenience, not the record of truth. logs/<name>.state is.

Wave 6 — second on-device feedback round: COMPLETE, verified 2026-09-09

The user tested the phone build again and sent eight items. All eight are done. Two Sonnet workers (tasks/H1-screens.txt, tasks/H2-picker.txt) took the UI work; the ORCHESTRATOR did the retry/backoff work itself in data/metadata and AppContainer, because it needed the live measurement below to design it.

Check Result
./tasks/gw assembleDebug exit 0
./tasks/gw testDebugUnitTest exit 0 — 172 tests, 1 skipped, 0 failures (was 138)
./tasks/gw verifyPaparazziDebug exit 0
grep "always 'false'" on a --rerun-tasks rebuild 0 hits
./tasks/gw assembleRelease exit 0 — 41,810,740 bytes, V2 signer CN=Bookshelf, O=Montanaro
boundary check clean — neither worker touched a build file or the other's packages

The ghost bookcase was an inset bug, not a data bug

LocationsScreen's list branch dropped the Scaffold's innerPadding while its empty-state branch applied it, so the FIRST bookcase row rendered underneath the top app bar and was invisible. Every symptom the user described follows from that: invisible first bookcase, no empty state on re-entry (the list was genuinely non-empty), a second bookcase created, both showing in the filter menu. Both records were always real and healthy — the user should delete the spare. Every other screen was checked for the same class of bug; Locations was the only one. Fix: fold innerPadding into the LazyColumn's contentPadding (NOT Modifier.padding, which would clip the scroll area instead of insetting it).

Metadata: measured, not guessed

See docs/METADATA-SOURCES.md § "Measured again 2026-09-09" for the full data. Two things that change how you should think about this app:

  1. Google Books keyless is dead for everyone, permanently. The user's residential-IP test returned a quota error naming project_number:624717413613 — a shared anonymous project, not an IP. The old note in METADATA-SOURCES.md guessing that a residential IP "may well get answers" is now marked CORRECTED in place. Because combine() turns any Failed-with-no-Found into Unavailable, this standing failure meant every Open Library hiccup surfaced as "one or more sources couldn't be reached". The app has been single-sourced all along. The user has deliberately deferred the API key — do not add it unasked.
  2. Our own timeouts were manufacturing failures. 30 live requests: 13% failed, all fast TLS resets (<2.5s); successes had a median of 4.3s but a max of 22.0s, and 2 of 26 successes exceeded the old 12s callTimeout. Timeouts are now 25s/20s/20s. Failures are fast and successes are slow, so a short timeout buys nothing on the failure path and costs real successes on the slow path.

RetryPolicy + withRetry (new, data/metadata/) retry TRANSPORT and SERVER_ERROR only. It deliberately does NOT retry:

  • TIMEOUT — the budget is already spent; retrying could triple the wait.
  • RATE_LIMITED — hammering a quota is how an intermittent block becomes a permanent one, and METADATA-SOURCES.md records that happening to this project's IP. Revisit when the Google Books key lands: a keyed 429 is a per-second limit and does deserve one Retry-After-respecting retry. SourceResult.Failed now carries a FailureKind alongside its human reason, and reason names the specific exception ("tls connection reset, 3 attempts") instead of a generic "network error". That string is now rendered on the scan sheet and is our ONLY diagnostic channel from a real phone. Nothing may parse it.

Known-soft spots in wave 6 — do not mistake these for verified

  1. The Paparazzi "regression" snapshot for the ghost bookcase is a lookalike, not the real screen. LocationsScreenPaparazziTest hand-rolls its own Scaffold+LazyColumn copy because the real LocationsScreen needs an AppContainer (Room + DataStore). The orchestrator verified the REAL fix by reading the diff; the PNG only proves the test's copy is right, and the two can drift — the copy already omits the bottom inset the real screen adds. Splitting a stateless LocationsContent(state, callbacks) out of the screen would make this snapshot genuine. Worth doing before anyone trusts it as regression cover.
  2. The auto-focus calls are unverified. Three dialogs now do LaunchedEffect(Unit) { runCatching { focusRequester.requestFocus() } }. That is the idiomatic form, but there is no emulator here and runCatching means a too-early call fails SILENTLY rather than crashing. If a dialog opens unfocused on the phone, that is why; the fix is to await a frame before requesting.
  3. The shelf picker opens as a bottom sheet stacked on top of the save sheet (H2's own flagged judgement call). It renders correctly in Paparazzi but sheet-over-sheet is awkward on real Android. Watch it on the device.

Worker lessons (both are repeats — the prompts already forbade them)

  • H1 backgrounded a Gradle build and ended its turn, exactly the wave-4 failure, despite an explicit foreground-only instruction AND CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS=0 being set in run-task.sh. Its final message was "I'll wait for this background build to complete." run-task.sh still recorded SUCCESS because the process exited 0. .state saying SUCCESS means the process exited cleanly, NOT that the worker finished its task — read logs/<name>.summary and check that the result is an actual report. H1's work was fine, but nobody verified it except the orchestrator.
  • H2 (108 turns, $4.00) followed the brief closely, ran builds in the foreground, and reported honestly, including flagging its own stacked-sheet judgement call. Cost ratio to H1 ($0.66, 5 turns) is roughly the ratio of work actually done.

Wave 7 — I-gbkey (Google Books API key): COMPLETE, verified by the orchestrator 2026-09-11

Prompt: tasks/I-gbkey.txt. The user asked for the key on 09-11, which lifts the standing "do not add it unasked" instruction recorded in wave 6.

Split of work, deliberately: the ORCHESTRATOR did the build plumbing (app/app/build.gradle.kts: read GOOGLE_BOOKS_API_KEY from local.properties, enable buildConfig, emit BuildConfig.GOOGLE_BOOKS_API_KEY) and verified it green BEFORE launching the worker, because workers on this project are barred from build files. The Sonnet worker did the Kotlin against a tree where the key was already available. Reuse this pattern for anything needing a build-file change.

Check Result
./tasks/gw assembleDebug exit 0
./tasks/gw testDebugUnitTest --rerun-tasks exit 0 — 189 tests, 1 skipped, 0 failures (was 172)
test count source summed from TEST-*.xml, not the console
./tasks/gw verifyPaparazziDebug exit 0 — no pixels moved, as intended
./tasks/gw assembleRelease exit 0 — 41,810,740 bytes
grep "always 'false'" on a --rerun-tasks build 0 hits
boundary check clean — worker touched only data/metadata + the one AppContainer line
key-leak check git grep finds no real key in the tree; tests use test-key-123
live API check HTTP 200 for both previously-failing ISBNs and a control

The worker's report was honest: every claim re-verified, including the test count, and it flagged its own judgement calls (how it reconciled the slightly ambiguous Retry-After cap wording) rather than papering over them. 51 turns, $1.59.

The live check was not ceremony. HttpUrl.Builder percent-encodes the colon, so the app sends q=isbn%3A... where every earlier hand-run test sent q=isbn:.... Offline tests cannot distinguish those. Verified: the API accepts both.

Both books that failed on the phone are in Google Books — so the restored fallback now covers exactly the Open Library TLS-reset failure mode that actually broke those two scans. The app has been effectively single-sourced since it was written and is now genuinely two-sourced. Details in docs/METADATA-SOURCES.md § "The key landed".

HAZARD #9 — run-task.sh reads the WORKER'S OWN OUTPUT for quota strings

run-task.sh's quota detector greps the worker's result blob for usage limit|...|429|too many requests|.... That blob includes .result — the worker's own prose. This wave's task was ABOUT HTTP 429, so the moment the worker finished and wrote a report mentioning 429, the runner declared QUOTA hit (wait #1), slept 600s, and was about to --resume a session that had already SUCCEEDED — which would have burned quota redoing finished work and let a fresh worker turn loose on a completed tree.

Caught it by checking the log rather than trusting the state line: jq '{is_error, subtype, num_turns}' logs/I-gbkey.json said is_error:false, subtype:"success", num_turns:51. The orchestrator killed the runner (PID from ps -o pid,args -p <pid>, per HAZARD #6 — not pkill -f) before the sleep elapsed, and appended a note to logs/<name>.state saying why.

Before believing any QUOTA hit line, check whether the worker actually finished: a non-empty logs/<name>.json with is_error:false means it SUCCEEDED and the runner is about to waste a session.

FIXED 2026-09-12 in run-task.sh itself (safe: no workers were running — the standing rule is only about editing it while a wave is live). Two defences, because either alone would have prevented this:

  1. The detector blob is now stderr plus jq -r 'select(.is_error==true) | .result' — the worker's prose reaches it ONLY when the run actually errored. If the log isn't valid JSON at all (a hard crash), it falls back to the whole log, where there is no prose to be confused by.
  2. The success check moved ABOVE the quota and session-vanished checks. A finished worker is finished regardless of what strings appear in its output.

Regression-checked against the real logs/I-gbkey.json that caused this: the old logic matches the quota pattern, the new logic yields SUCCESS and feeds the detector an empty blob.